Feature: util hash #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lancern merged 8 commits into cppdoc-cc:main from HOMODELUNA:feature/util-hash-2026.01.06

Feb 3, 2026

Contributor

HOMODELUNA commented Jan 6, 2026

migrate std::hash from https://en.cppreference.com/w/cpp/utility/hash.html

migrate std::hash<Key>::operator() from https://en.cppreference.com/w/cpp/utility/hash/operator().html

HOMODELUNA added 3 commits

January 6, 2026 16:37


          feat(): page: util hash

0915d58


          feat(std::hash): page for operator()

6f4d624


          fix(std::hash): use doclink

74fd43c

vercel bot commented Jan 6, 2026

@HOMODELUNA is attempting to deploy a commit to the microcber's projects Team on Vercel.

A member of the Team first needs to authorize it.

Lancern requested changes

View reviewed changes

Collaborator

Lancern left a comment

The operator() page looks good, but the std::hash page needs some major changes, including utility component enhancements.

src/content/docs/cpp/library/utility/hash.mdx Outdated

Comment on lines 16 to 46

+              Defined in header <CppHeader name="bitset" />.
+              Defined in header <CppHeader name="coroutine" />.
+              Defined in header <CppHeader name="chrono" />.
+              Defined in header <CppHeader name="filesystem" />.
+              Defined in header <CppHeader name="functional" />.
+              Defined in header <CppHeader name="memory" />.
+              Defined in header <CppHeader name="optional" />.
+              Defined in header <CppHeader name="stacktrace" />.
+              Defined in header <CppHeader name="string" />.
+              Defined in header <CppHeader name="string_view" />.
+              Defined in header <CppHeader name="system_error" />.
+              Defined in header <CppHeader name="text_encoding" />.
+              Defined in header <CppHeader name="thread" />.
+              Defined in header <CppHeader name="typeindex" />.
+              Defined in header <CppHeader name="variant" />.
+              Defined in header <CppHeader name="vector" />.

Collaborator

Lancern Jan 13, 2026

This series of header files take too much screen space on the page. I think we have to come up with a way to get around this.

src/content/docs/cpp/library/utility/hash.mdx Outdated

+              -   If `std::hash<Key>` is not provided by the program or the user, it is disabled.
+              -   Otherwise, `std::hash<Key>` is enabled if all following conditions are satisfied:
+                  -   All following requirements are satisfied:
+                      -   [Hash](../named_req/Hash.html "cpp/named req/Hash") (with `Key` as the function call argument type)

Collaborator

Lancern Jan 13, 2026

Please use <DocLink> for all cross links within cppdoc.

src/content/docs/cpp/library/utility/hash.mdx Outdated


		Given a type `Key`, each specialization `std::hash<Key>` is either _enabled_ or _disabled_ :

		- If `std::hash<Key>` is not provided by the program or the user, it is disabled.

Collaborator

Lancern Jan 13, 2026

Please leave only one space between - and If.

src/content/docs/cpp/library/utility/hash.mdx

Comment on lines +102 to +105

+              | | |
+              |---|---|
+              |(constuctor) | <Desc kind="public member function">constructs a hash function object </Desc>|
+              |<DocLink dest="/cpp/library/utility/hash/operator-call"> `operator()` </DocLink> | <Desc kind="public member function">calculates the hash of the argument </Desc>|

Collaborator

Lancern Jan 13, 2026

Same here. This is not right. We need to implement a component for such content.

src/content/docs/cpp/library/utility/hash.mdx Outdated


		Possible outputs:

		```cpp

Collaborator

Lancern Jan 13, 2026

This code block does not contain C++ source code.

src/content/docs/cpp/library/utility/hash.mdx

+              | [LWG 2119](https://cplusplus.github.io/LWG/issue2119) | C++11 | specializations for extended integer types were missing | provided |
+              | [LWG 2148](https://cplusplus.github.io/LWG/issue2148) | C++11 | specializations for enumerations were missing | provided |
+              | [LWG 2543](https://cplusplus.github.io/LWG/issue2543) | C++11 | `std::hash` might not be SFINAE-friendly | made SFINAE-friendly |
+              | [LWG 2817](https://cplusplus.github.io/LWG/issue2817) | C++11 | specialization for [std::nullptr\_t](../types/nullptr_t.html "cpp/types/nullptr_t") was missing | provided |

Collaborator

Lancern Jan 13, 2026

Please use <DRList> for defect reports list.

Contributor Author

HOMODELUNA Jan 20, 2026

in my new commit from the same franch, I fixed these problems, and added relevant name requesitions, what should I do then?

HOMODELUNA added 4 commits

January 21, 2026 01:02


          feat(named_req) Hashable, DefaultConstructible, Destructible

35e9b89


          feat(hash): update link

3d7d464


          feat(named_req): Swappable, CopyAssignable

f89163e


          feat(hash): update links

1b8a92e

Contributor Author

HOMODELUNA commented Jan 23, 2026

in my new commit from the same franch, I fixed these problems, and added relevant name requesitions, what should I do then?

Is there anything I can do to fix the task?

Collaborator

Lancern commented Jan 25, 2026

Is there anything I can do to fix the task?

No, the task is broken for now. I'll fix it later.

Lancern previously approved these changes

View reviewed changes

Collaborator

Lancern left a comment

Please fix another two nits. After fixed I'll land this PR first.

src/content/docs/cpp/language/named_req/_meta.yml Outdated

		@@ -0,0 +1 @@
		label: Name Requirements

Collaborator

Lancern Feb 3, 2026

Suggested change

      
            label: Name Requirements
          
            label: Named Requirements

src/content/docs/cpp/language/named_req/copy-asssignable.mdx Outdated

		@@ -0,0 +1,59 @@
		---
		title: "C++ named requirements: CopyAssignable"

Collaborator

Lancern Feb 3, 2026

Suggested change

      
            title: "C++ named requirements: CopyAssignable"
          
            title: "CopyAssignable"

Please also apply similar modifications to other page titles in this PR.

Contributor Author

HOMODELUNA Feb 3, 2026

fixed in commit 46972ee


          fix(named_req): nix, and remove prefix "Named Requirements"

46972ee

HOMODELUNA dismissed Lancern’s stale review via

46972ee

February 3, 2026 14:28

Lancern approved these changes

View reviewed changes

Lancern merged commit bfd8726 into cppdoc-cc:main

2 of 3 checks passed

Collaborator

Lancern commented Feb 3, 2026

Thanks!

This PR still has some formatting issues, but let's land it for now and later I'll address these issues in separate patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet